Fix Python dtype conversion for int64 on Windows. #12880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
platform/windows 🚪
ScottTodd
requested review from
GMNGeoffrey,
pzread and
stellaraccident
as code owners
ScottTodd
commented
Mar 31, 2023
Comment on lines
+414
to
+421
| // See: | ||
| // * https://numpy.org/doc/stable/reference/arrays.dtypes.html | ||
| // * https://docs.python.org/3/c-api/arg.html#numbers | ||
| // | ||
| // Single letter codes can be ambiguous across platforms, so prefer explicit | ||
| // bit depth values, ("Type strings: Any string in numpy.sctypeDict.keys()"). | ||
| // See https://github.com/pybind/pybind11/issues/1908 | ||
| const char* dtype_string; |
There was a problem hiding this comment.
Hey @Eliasj42 , this is changing the same code as your #12872 (nice timing on that and @allieculp 's ping on the Windows issue!). I think adding a complex test case to runtime/bindings/python/tests/vm_types_test.py might be enough for your PR, but we should also add more e2e tests using complex to ensure it works across all the layers.
jpienaar
approved these changes
Apr 3, 2023
Yeah, the newly enabled test covers this. We could still use some pure-python (no TF / other frameworks) tests that go through a more complete workflow with each data type though. |
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
Fixes #11080. The int64 and uint64 test cases here were failing on Windows as the element type mapping was routing via the code `l`, which is a "C long int" - not an explicitly 64 bit type. This changes the mapping to always use the explicit "type strings" (any string in `numpy.sctypeDict.keys()`, [shown in this gist](https://gist.github.com/ScottTodd/ec1f7906e9c644eb47f74280d6c26229)). Relates to #12872
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
Fixes iree-org#11080. The int64 and uint64 test cases here were failing on Windows as the element type mapping was routing via the code `l`, which is a "C long int" - not an explicitly 64 bit type. This changes the mapping to always use the explicit "type strings" (any string in `numpy.sctypeDict.keys()`, [shown in this gist](https://gist.github.com/ScottTodd/ec1f7906e9c644eb47f74280d6c26229)). Relates to iree-org#12872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11080. The int64 and uint64 test cases here were failing on Windows as the element type mapping was routing via the code
l, which is a "C long int" - not an explicitly 64 bit type. This changes the mapping to always use the explicit "type strings" (any string innumpy.sctypeDict.keys(), shown in this gist).Relates to #12872